Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix fsUtils is not defined at taobao platform #15522

Merged
merged 2 commits into from
Jun 26, 2023
Merged

fix fsUtils is not defined at taobao platform #15522

merged 2 commits into from
Jun 26, 2023

Conversation

bofeng-song
Copy link
Contributor

Re: #

Changelog

Continuous Integration

This pull request:

  • needs automatic test cases check.

    Manual trigger with @cocos-robot run test cases afterward.

  • does not change any runtime related code or build configuration

    If any reviewer thinks the CI checks are needed, please uncheck this option, then close and reopen the issue.

Compatibility Check

This pull request:

  • changes public API, and have ensured backward compatibility with deprecated features.
  • affects platform compatibility, e.g. system version, browser version, platform sdk version, platform toolchain, language version, hardware compatibility etc.
  • affects file structure of the build package or build configuration which requires user project upgrade.
  • introduces breaking changes, please list all changes, affected features and the scope of violation.

@bofeng-song bofeng-song requested a review from PPpro June 25, 2023 07:55
PPpro
PPpro reviewed Jun 25, 2023
View reviewed changes
pal/wasm/wasm-minigame.ts Outdated Show resolved Hide resolved
@github-actions
Copy link

Interface Check Report

This pull request does not change any public interfaces !

@bofeng-song bofeng-song requested a review from minggo June 25, 2023 09:21
@minggo
Copy link
Contributor

minggo commented Jun 25, 2023

@cocos-robot run test cases

@github-actions
Copy link

@bofeng-song, Please check the result of run test cases:

Task Details

@bofeng-song
Copy link
Contributor Author

@cocos-robot run test cases

@github-actions
Copy link

@bofeng-song, Please check the result of run test cases:

Task Details

Platform build boot runned crashScene FailScene
web-mobile PASS PASS FAIL Morph-Head,deprecated,rich-text-align,rich-text-long-string-truncation,mask-type-change,mask-use-image-stencil,sharedMaterial,rich-text,system-font
windows PASS PASS FAIL label-cacheMode,label-align,ttf-font
ios PASS PASS FAIL ReplaceSlotDisplay
android PASS PASS PASS
mac PASS PASS PASS

@minggo minggo merged commit bd28997 into cocos:v3.8.0 Jun 26, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@minggo minggo minggo approved these changes

@PPpro PPpro PPpro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bofeng-song @minggo @PPpro